Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected lut mode #7

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Corrected lut mode #7

merged 3 commits into from
Aug 7, 2024

Conversation

radarhere
Copy link

Suggestions for python-pillow#8290

akx
akx approved these changes Aug 7, 2024
View reviewed changes
Copy link
Owner

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I somewhat disagree with the parametrize string mode – I think separate parameters are easier to visually grep, and that's what I'm used to :)

But that's fine.

@akx akx merged commit a06529a into akx:parametrize-lut-tests Aug 7, 2024
44 checks passed
@radarhere radarhere deleted the parametrize-lut-tests branch August 7, 2024 09:14
@akx
Copy link
Owner

akx commented Aug 7, 2024 •
edited
Loading

@radarhere Btw, according to https://docs.astral.sh/ruff/rules/pytest-parametrize-names-wrong-type/ both styles are being used in Pillow right now. csv style overwhelmingly more, but there are some tuple cases too.

(See: python-pillow#8295)

@akx akx mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akx akx akx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radarhere @akx